Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Saving, Loading and Verifying progress bars #170

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Align Saving, Loading and Verifying progress bars #170

merged 5 commits into from
Nov 19, 2024

Conversation

will-v-pi
Copy link
Contributor

Align all the Saving, Loading and Verifying progress bars, by placing them at the longest possible prefix. Also prevent saving/loading from the RP2040 unstriped SRAM, as that returns an error from the device, and would increase the length of the longest possible prefix.

This changes the output from

$ picotool save -v flash.bin -r 0x10000000 0x10040000
Saving file: [==============================]  100%
Wrote 262144 bytes to flash.bin
Verifying Flash:    [==============================]  100%
  OK
$ picotool load -v flash.bin 
Loading into Flash: [==============================]  100%
Verifying Flash:    [==============================]  100%
  OK

to

$ picotool save -v flash.bin -r 0x10000000 0x10040000
Saving file:          [==============================]  100%
Wrote 262144 bytes to flash.bin
Verifying Flash:      [==============================]  100%
  OK
$ picotool load -v flash.bin 
Loading into Flash:   [==============================]  100%
Verifying Flash:      [==============================]  100%
  OK

@will-v-pi will-v-pi requested a review from kilograham November 8, 2024 13:46
lurch
lurch reviewed Nov 11, 2024
View reviewed changes
main.cpp Outdated Show resolved Hide resolved
@will-v-pi
Only calculate longest_mem_str once, when progress_bar is created
c76ca9f
@will-v-pi
Fix saving/verifying range to bin file
617790d 
When verifying the bin file was assumed to start at FLASH_START, so verification would fail if the range didn't start there
lurch
lurch reviewed Nov 12, 2024
View reviewed changes
main.cpp Outdated Show resolved Hide resolved
@will-v-pi will-v-pi merged commit 7350867 into develop Nov 19, 2024
35 checks passed
@will-v-pi will-v-pi deleted the align-bars branch November 19, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

@kilograham kilograham Awaiting requested review from kilograham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@will-v-pi @lurch