setting MAX_LEVEL based on actual mipcount input #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JettMonstersGoBoom merging but... is this parameter supported in all OpenGL required versions by the function? |
it looks like it's supported in GLES2.0 too actually, you could safely move outside of the #ifdef I think. I don't have the setup to test that. I put it there because MIPS are automatically enabled by the filter change above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the user supplies less mips than would be generated normally the texture rendering will break.
for example quake1&2 and halflife have 4 pre-generated mips included with the data, viewing those textures without this fix would result in visual errors.