[rmodels] Fix normal transform in UpdateModelAnimationBones
#4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the force push, I just renamed the commit messages because I made a mistake, and they would have poorly represented the history. Nothing else was changed. |
|
@Bigfoot71 thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested here: #4581 (comment)
I fixed the function by transforming the normals using only the rotational part of the transformation matrix, obtained via its inverse transpose.
I also simplified the inversion of the quaternion
inRotation, which was being calculated twice within the same scope.Edit: the examples
models_animation,models_bone_socket, andmodels_loading_gltfwere successfully (re)tested.