Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge package.json and GitHub topics, update and cleanup libraries #495

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

Simek
Copy link
Member

@Simek Simek commented Oct 28, 2020

Why

Refs #484

This PR improves the topics gathered for library and search string generation. The current flow has been simplified and package.json keywords will be always extracted. For non-monorepo packages also the GitHub topic will be added (and the merge list will be deduplicated).

This is not the full fix for the reference issues, but it should improve the search UX a bit.

Example of updated tags for audio-toolkit

image

In addition the topics are being processed to address the whitespace character allowed in package.json keywords.

During work on the changes I have noticed one deleted library and few small warnings about moved packages - those problems have been also addressed.

The last thing included in this PR is updated libraries:cleanup script which includes now prettier step like the pre-commit hook, so the cleanup results are consistent with final reformat.

Checklist

If you added a feature or fixed a bug:

  • Documented in this PR how to use the feature or replicate the bug.
  • Documented in this PR how you fixed or created the feature.

@Simek Simek requested a review from brentvatne October 28, 2020 12:51
@brentvatne brentvatne merged commit f54c15c into react-native-community:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants