Support Image Symbol Names (e.g. SF Symbols) #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
reviewed
Apr 27, 2024
|
|
||
| ## Alternatives | ||
|
|
||
| - Use `react-native-sfsymbols` |
There was a problem hiding this comment.
another good option: https://docs.expo.dev/versions/v51.0.0/sdk/symbols/
imo this is sufficient, in particular given #759 - which will see React Native move towards recommending using a React Native Framework like Expo and keeping a focused core. note that any platform-specific APIs in React Native core increase the surface area for out of tree platforms.
further, I'm not convinced that the Image component from react-native is actually the best tool to use for most apps. there is a greater discussion to be had about this, but in general most folks building larger apps will use expo-image or react-native-fast-image instead due to the better perceived "feel" and objective performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal suggests adding support for custom symbol images in React Native's
Imagecomponent. Currently, React Native supports loading images from local files and network URLs. However, there's no direct support for using custom symbol images on iOS/macOS/tvOS. This feature would improve developers' ability to use React Native to create a native look and feel without relying on third-party libraries.