Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test build type for android_build #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matinzd
Copy link

@matinzd matinzd commented May 20, 2022

Add test_build_type to build_android job and command.

@matinzd
Copy link
Author

matinzd commented May 20, 2022

@cortinico

@cortinico
Copy link
Member

Could you make an example on why this is needed @matinzd ?

@matinzd
Copy link
Author

matinzd commented May 24, 2022

In some react native projects there are different types of flavors are configured for the project based on the needs, but test flavors are not configured or they have different test build type.

Copy link
Member

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but test flavors are not configured or they have different test build type.

I don't have a strong opinion on this. It feels a bit unnecessary to me, but I believe there could be scenarios where this is useful for some.

We can merge this imho. The problem is that I believe the token expired so CircleCI is red at the moment. I'm unsure who can help us here

@fotos fotos force-pushed the feat_add_test_build_type branch 2 times, most recently from dc60eab to ee8a478 Compare February 3, 2024 19:12
@fotos
Copy link
Collaborator

fotos commented Feb 3, 2024

@matinzd now that the CI/CD pipeline has been fixed, this needs a rebase.

@cortinico if this is still useful feel free to merge. 🚀

@fotos fotos force-pushed the feat_add_test_build_type branch from ee8a478 to 6645ae5 Compare February 10, 2024 10:37
@cortinico
Copy link
Member

@cortinico if this is still useful feel free to merge. 🚀

I don't have a strong opinion here. We're not using this orb internally and I'll leave the decision to merge to you folks

@fotos fotos force-pushed the feat_add_test_build_type branch from 6645ae5 to f1bd0ba Compare February 12, 2024 18:24
@fotos fotos force-pushed the feat_add_test_build_type branch from f1bd0ba to a9e36e6 Compare May 23, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants