Fix issue with AppName stripping incorrectly.

Handles cases where appName is empty.
react-native-community · Feb 26, 2024 · cca3815 · cca3815
1 parent b6bbf79
commit cca3815
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/__tests__/utils.spec.ts b/src/__tests__/utils.spec.ts
@@ -2,6 +2,7 @@ import { PACKAGE_NAMES } from '../constants'
 import '../releases/__mocks__/index'
 import {
   getVersionsContentInDiff,
+  removeAppPathPrefix,
   replaceAppDetails,
   getChangelogURL,
 } from '../utils'
@@ -132,3 +133,21 @@ describe('replaceAppDetails ', () => {
     }
   )
 })
+
+describe('removeAppPathPrefix', () => {
+  test.each([
+    ['RnDiffApp/package.json', 'package.json'],
+    ['RnDiffApp/RnDiffApp.ts', 'RnDiffApp.ts'],
+  ])('removeAppPathPrefix("%s") -> "%s"', (path, newPath) => {
+    expect(removeAppPathPrefix(path)).toEqual(newPath)
+  })
+
+  test('removeAppPathPrefix custom AppName', () => {
+    expect(removeAppPathPrefix('RnDiffApp/package.json', '')).toEqual(
+      'RnDiffApp/package.json'
+    )
+    expect(removeAppPathPrefix('Foobar/package.json', 'Foobar')).toEqual(
+      'package.json'
+    )
+  })
+})
diff --git a/src/utils.ts b/src/utils.ts
@@ -75,7 +75,7 @@ export const getBinaryFileURL = ({
 }
 
 export const removeAppPathPrefix = (path: string, appName = DEFAULT_APP_NAME) =>
-  path.replace(new RegExp(`${appName}/`), '')
+  path.replace(new RegExp(`^${appName}/`), '')
 
 /**
  * Replaces DEFAULT_APP_PACKAGE and DEFAULT_APP_NAME in str with custom