removed test_krb_user_ldap_mapping, fixing issued with V3 adoption and add --keep-sssd flag #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was removed for several reasons: 1) The test was never really working. The only reason it was passing was because of sssd caching. 2) The test in order to work needs a lot of extra parameters in sssd configuration and there is neither the knowledge nor the time to invest in learning it. 3) The LDAP mapping is not really used in our days and we believe that the case the test is testing is very rare.
1) Sanity/test_smart_card_detection.py::test_pam_services_config: added new line at the end on /etc/pam.d/pam_cert_service 2) Sanity/test_sssd_conf.py::test_matchrule_defined_for_other_user: fix the way it replaces certmap/shadowutils section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was removed for several reasons:
because of sssd caching.
configuration and there is neither the knowledge nor the time to
invest in learning it.
the case the test is testing is very rare.
Fix small errors for the tests to be compatible with V3:
new line at the end on /etc/pam.d/pam_cert_service
the way it replaces certmap/shadowutils section
add --keep-sssd flag