Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure independence of metadata / linking config #27

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

librarianmage
Copy link
Contributor

I realized I made a mistake in #26's logic where adding metadata would happen if match_metadata was False, match_metadata_name was directly set, and link_transactions was True. This PR fixes that logic and adds a test to ensure that the two sets of options don't accidentally enable each other.

@redstreet redstreet merged commit 8867cf4 into redstreet:main Apr 20, 2024
3 checks passed
@redstreet
Copy link
Owner

Thanks for catching this. Merged. I'll test it out in the next few weeks on my personal journal before making a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants