Skip to content

Commit

Permalink
Merge branch 'robert/cosmos-sdk-047' into pjestrada/fix-finite-tests
Browse files Browse the repository at this point in the history
# Conflicts:
#	types/math/dec_test.go
  • Loading branch information
Pablo Estrada committed Dec 7, 2024
2 parents f8970ff + fee4996 commit 4cc264d
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions types/math/dec_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,7 @@ func TestIsFinite(t *testing.T) {
b, err := NewDecFromString("NaN")

Check failure on line 622 in types/math/dec_test.go

View workflow job for this annotation

GitHub Actions / golangci (types)

ineffectual assignment to b (ineffassign)
require.EqualError(t, err, "not a number: invalid decimal string")
// empty decimal has finite form by default
b, err = NewDecFromString("")

Check failure on line 625 in types/math/dec_test.go

View workflow job for this annotation

GitHub Actions / golangci (types)

ineffectual assignment to err (ineffassign)
require.True(t, b.IsFinite())
}

Expand Down

0 comments on commit 4cc264d

Please sign in to comment.