Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integration tests for cosmos v0.47 upgrade #2227

Conversation

PJEstrada
Copy link
Contributor

@PJEstrada PJEstrada commented Dec 7, 2024

Description

Build on top of #2226 Some tests were failing due to not waiting for a block or bad sequence usage. Also refactored the invalid resolver id test case to check for the error string and fix the error message


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@PJEstrada PJEstrada changed the base branch from main to robert/cosmos-sdk-047 December 7, 2024 07:30
@PJEstrada PJEstrada mentioned this pull request Dec 7, 2024
19 tasks
Pablo Estrada added 2 commits December 7, 2024 16:18
accounts were being initialized with insufficient balance and needed to wait for blocks during
init txs for the suite.
Most of the tests were failing because we were not waiting for the next block, which caused sequence issues. There are still some flaky tests
@JeancarloBarrios JeancarloBarrios merged commit 3914107 into regen-network:robert/cosmos-sdk-047 Dec 9, 2024
16 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants