Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/gitlab-packages): prefer checking for conan_package_name if it exists #33099

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

FFace32
Copy link

@FFace32 FFace32 commented Dec 13, 2024

Changes

Checks if conan_package_name exists and matches the filtered package name for the gitlab-packages datasource.

Context

When querying for uploaded Conan packages on GitLab, the name value contains the version and the channel as well, and this doesn't pass the filter in lib/modules/datasource/gitlab-packages/index.ts.

conan_package_name, if it exists, contains only the package name.

This can also be seen in the GitLab documentation as an example here: https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/api/packages.md?plain=1#L69-70

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@rarkins rarkins enabled auto-merge December 14, 2024 06:43
auto-merge was automatically disabled December 14, 2024 12:30

Head branch was pushed to by a user without write access

@FFace32 FFace32 requested a review from rarkins December 16, 2024 09:52
rarkins
rarkins previously approved these changes Dec 17, 2024
@FFace32
Copy link
Author

FFace32 commented Dec 17, 2024

Should I update the index.spec.ts.snap snapshot?

It seems like that's the reason the pipeline fails.

@FFace32
Copy link
Author

FFace32 commented Dec 22, 2024

Should I update the index.spec.ts.snap snapshot?

It seems like that's the reason the pipeline fails.

Sorry, didn't see the thumbs up until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants