Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset): fix axis2 monorepo group #33293

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Conversation

jadefr
Copy link
Contributor

@jadefr jadefr commented Dec 26, 2024

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

- axis2:mex and axis2:addressing were still getting updated separately, despite of the axis2 grouping.

- For this reason, axis2 was refactored to be grouped by group id instead of source url.

- mex and addressing are contained within modules and follow the same version:
  https://repo1.maven.org/maven2/org/apache/axis2/axis2/1.8.2/axis2-1.8.2.pom
  https://github.com/apache/axis-axis2-java-core/tree/master/modules
@viceice viceice changed the title Feat(preset): Fix axis2 monorepo group feat(preset): fix axis2 monorepo group Dec 27, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you tried to upstream the source url changes, so renovate can properly detect grouping.

@viceice
Copy link
Member

viceice commented Dec 27, 2024

you can also add manual source urls

"com.figure.gradle.semver-plugin:com.figure.gradle.semver-plugin.gradle.plugin": "https://github.com/FigureTechnologies/gradle-semver-plugin"

@rarkins rarkins added this pull request to the merge queue Dec 28, 2024
Merged via the queue into renovatebot:main with commit f26181d Dec 28, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.84.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants