-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Collect license used to install cluster in support bundles #1601
feat: Collect license used to install cluster in support bundles #1601
Conversation
Signed-off-by: Evans Mungai <[email protected]>
Signed-off-by: Evans Mungai <[email protected]>
41f52a8
to
e5596a3
Compare
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer:
Airgap Installer (may take a few minutes before the airgap bundle is built):
Happy debugging! |
Signed-off-by: Evans Mungai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM overall, wondering what you think about adding a test for this changes?
My suggestion would be to piggy back on the dryrun tests we have for the install
command (which should be relatively quick to do) here:
embedded-cluster/tests/dryrun/install_test.go
Lines 19 to 40 in 2c21588
func TestDefaultInstallation(t *testing.T) { dr := dryrunInstall(t) // --- validate os env --- // assertEnv(t, dr.OSEnv, map[string]string{ "TMPDIR": "/var/lib/embedded-cluster/tmp", "KUBECONFIG": "/var/lib/embedded-cluster/k0s/pki/admin.conf", }) // --- validate commands --- // assertCommands(t, dr.Commands, []interface{}{ regexp.MustCompile(`k0s install controller .* --data-dir /var/lib/embedded-cluster/k0s`), }, false, ) // --- validate host preflight spec --- // assertCollectors(t, dr.HostPreflightSpec.Collectors, map[string]struct { match func(*troubleshootv1beta2.HostCollect) bool validate func(*troubleshootv1beta2.HostCollect) }{
Signed-off-by: Evans Mungai <[email protected]>
well, that solution.... did not work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the change with Andrew in person. Passing the short sha variable is not great, but it's a good solution for now
What this PR does / why we need it:
<data-dir>
Demo: https://asciinema.org/a/uhpIRKKc5C9k7MtP1ovI69Kte
I missed showing the file permissions of
license.yaml
in the demoWhich issue(s) this PR fixes:
sc-116758
Does this PR require a test?
NONE
Does this PR require a release note?
Does this PR require documentation?
NONE