Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-117743] preflight check: ensure valid nameservers in /etc/resolv.conf #1665

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

nvanthao
Copy link
Member

@nvanthao nvanthao commented Dec 23, 2024

Story details: https://app.shortcut.com/replicated/story/117743

I used less strict regex to validate IP address for readability.

Copy link

github-actions bot commented Dec 23, 2024

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-aa0a1e6" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-aa0a1e6?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@nvanthao nvanthao marked this pull request as draft December 23, 2024 04:03
@nvanthao nvanthao marked this pull request as ready for review December 24, 2024 01:16
@nvanthao nvanthao requested a review from adamancini December 24, 2024 01:16
@adamancini adamancini merged commit 8a95fbc into main Dec 30, 2024
67 checks passed
@adamancini adamancini deleted the gerard/sc-117743/coredns-nameserver-check branch December 30, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants