Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dr): use Status.CompletionTimestamp for sorting backups #1679

Conversation

emosbaugh
Copy link
Member

@emosbaugh emosbaugh commented Jan 2, 2025

What this PR does / why we need it:

The creation timestamp represents the time at which the CR was created in the new restore cluster and does not reflect the creation timestamp of the backup. Revert the change to use prior Status.CompletionTimestamp field.

Which issue(s) this PR fixes:

Does this PR require a test?

Does this PR require a release note?


Does this PR require documentation?

Copy link

github-actions bot commented Jan 2, 2025

This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID.

Online Installer:

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci/appver-dev-1f98295" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Airgap Installer (may take a few minutes before the airgap bundle is built):

curl "https://staging.replicated.app/embedded/embedded-cluster-smoke-test-staging-app/ci-airgap/appver-dev-1f98295?airgap=true" -H "Authorization: $EC_SMOKE_TEST_LICENSE_ID" -o embedded-cluster-smoke-test-staging-app-ci.tgz

Happy debugging!

@emosbaugh emosbaugh marked this pull request as ready for review January 2, 2025 20:23
@emosbaugh emosbaugh merged commit d09bbc7 into main Jan 2, 2025
67 checks passed
@emosbaugh emosbaugh deleted the emosbaugh/sc-118118/the-most-recent-backup-is-not-available-for branch January 2, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants