Skip to content

Quick Guidelines for Contributing to RepoSense

Lee Jin Yao edited this page Aug 14, 2019 · 3 revisions

This serves to guide the new developers who wish to make a pull request (PR) to RepoSense.

When working on something

When your work is still in-progress, you may make a draft PR (refer to the guide here.

Checklist before asking for a review

Ensure that the following items are checked before asking for a review:

Coding Style

RepoSense follows the following coding styles located here. Please ensure that the coding styles follow the link provided before requesting for a review.

Test Cases

Wherever possible, try to ensure that new features, behavioral changes and/or bug fixes are covered with test cases.

Updating of Documentation

Ensure that any changes that will render any part of the documentations to be outdated (such as UI updates, feature or behavioral changes) are updated accordingly.

Commit Messages when Making a PR

Note that PRs will be squashed before merging into the master branch. While it is not necessary to follow the guidelines on commit messages for individual commits, please ensure that the guidelines on commit message title and body are followed when making a PR.

For title of the PR

Ensure that the PR title follow the following convention.

  • Format: [PR Number] Area affected: Summary of change
  • Example: [#750] Zoom Tab: display commit message body

For the comment section of the PR

The body of the commit message should be written in the comment section, and should adhere to the following format.

Format:

{current situation} -- use present tense

{why it needs to change}

{what is being done about it} -- use imperative mood

{why it is done that way}

{any other relevant info}

Example:

In the zoom tab, only the commit message titles are listed.

The commit message title alone may be too abstract for users to 
understand the rationale of large implementations.

Let's display the commit message body below each commit message title 
so that users get more clarity to the purpose of each commits.

Also, each line in the commit message body should be limited to 72 characters.

Refer to the guide here for more information.