[Chore] Remove derive-getters

restatedev · Aug 13, 2024 · 0882041 · 0882041
1 parent be32505
commit 0882041
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 19 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -97,7 +97,6 @@ datafusion = { version = "40.0.0", default-features = false, features = [
     "unicode_expressions",
 ] }
 datafusion-expr = { version = "40.0.0" }
-derive-getters = { version = "0.4.0" }
 derive_builder = "0.20.0"
 derive_more = { version = "0.99.17" }
 dialoguer = { version = "0.11.0" }

diff --git a/crates/node/Cargo.toml b/crates/node/Cargo.toml
@@ -38,7 +38,6 @@ axum = { workspace = true }
 bytes = { workspace = true }
 codederror = { workspace = true }
 datafusion = { workspace = true }
-derive-getters = { workspace = true }
 derive_builder = { workspace = true }
 enum-map = { workspace = true }
 enumset = { workspace = true }

diff --git a/crates/rocksdb/Cargo.toml b/crates/rocksdb/Cargo.toml
@@ -21,7 +21,6 @@ anyhow = { workspace = true }
 bytes = { workspace = true }
 bytestring = { workspace = true }
 codederror = { workspace = true }
-derive-getters = { workspace = true }
 derive_builder = { workspace = true }
 derive_more = { workspace = true }
 futures = { workspace = true }

diff --git a/crates/rocksdb/src/db_spec.rs b/crates/rocksdb/src/db_spec.rs
@@ -11,7 +11,6 @@
 use std::path::PathBuf;
 
 use derive_builder::Builder;
-use derive_getters::Getters;
 
 use crate::{BoxedCfMatcher, BoxedCfOptionUpdater};
 
@@ -115,7 +114,7 @@ impl CfNameMatch for CfExactPattern {
     }
 }
 
-#[derive(Builder, Getters)]
+#[derive(Builder)]
 #[builder(pattern = "owned", build_fn(name = "build"))]
 pub struct DbSpec<T> {
     pub(crate) name: DbName,
@@ -143,10 +142,15 @@ pub struct DbSpec<T> {
     /// `UnknownColumnFamily` error
     pub(crate) cf_patterns: Vec<(BoxedCfMatcher, BoxedCfOptionUpdater)>,
     #[builder(setter(skip))]
-    #[getter(skip)]
     _phantom: std::marker::PhantomData<T>,
 }
 
+impl<T> DbSpec<T> {
+    pub fn name(&self) -> &DbName {
+        &self.name
+    }
+}
+
 impl<T> DbSpecBuilder<T> {
     pub fn new(name: DbName, path: PathBuf, db_options: rocksdb::Options) -> DbSpecBuilder<T> {
         Self {