Make more clear the old completed invocation case

restatedev · Aug 16, 2024 · c21f618 · c21f618
1 parent cf1593b
commit c21f618
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 6 deletions.
diff --git a/crates/storage-api/src/invocation_status_table/mod.rs b/crates/storage-api/src/invocation_status_table/mod.rs
@@ -627,5 +627,22 @@ mod test_util {
                 source_table: SourceTable::New,
             }
         }
+
+        pub fn mock_old() -> Self {
+            CompletedInvocation {
+                invocation_target: InvocationTarget::virtual_object(
+                    "MyService",
+                    "MyKey",
+                    "mock",
+                    VirtualObjectHandlerType::Exclusive,
+                ),
+                source: Source::Ingress,
+                idempotency_key: None,
+                timestamps: StatusTimestamps::now(),
+                response_result: ResponseResult::Success(Bytes::from_static(b"123")),
+                completion_retention_duration: Duration::from_secs(60 * 60),
+                source_table: SourceTable::Old,
+            }
+        }
     }
 }
diff --git a/crates/worker/src/partition/cleaner.rs b/crates/worker/src/partition/cleaner.rs
@@ -255,12 +255,8 @@ mod tests {
             ),
             (
                 not_expired_invocation_2,
-                InvocationStatus::Completed(CompletedInvocation {
-                    completion_retention_duration: Duration::ZERO,
-                    // StatusTimestamps::now() don't set the completed_transition_time()
-                    timestamps: StatusTimestamps::now(),
-                    ..CompletedInvocation::mock_neo()
-                }),
+                // Old status invocations are still processed with the cleanup timer in the PP
+                InvocationStatus::Completed(CompletedInvocation::mock_old()),
             ),
             (
                 not_completed_invocation,