Use net_util::run_hyper_server to run admin http server #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
approved these changes
Aug 15, 2024
tillrohrmann
force-pushed
the
admin-uses-hyper-server
branch
from
7c4fd30 to
07156dd
Compare
Since we are spawning the connection handling of the Admin HTTP server in the TaskCenter, we no longer need to spawn TaskCenter tasks from within the REST handlers.
tillrohrmann
force-pushed
the
admin-uses-hyper-server
branch
from
07156dd to
fbee26b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use net_util::run_hyper_server to run admin http server.
Remove TaskCenter from AdminServiceState
Since we are spawning the connection handling of the Admin HTTP server
in the TaskCenter, we no longer need to spawn TaskCenter tasks from
within the REST handlers.