Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Networking Add ability to register raw handlers in message router #1957

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Sep 11, 2024

[Networking Add ability to register raw handlers in message router

Also, this introduces a mechanism to subscribe to connection closed events via ConnectionSender


Stack created with Sapling. Best reviewed with ReviewStack.

@AhmedSoliman AhmedSoliman force-pushed the pr1957 branch 2 times, most recently from 514d7b8 to de80fa4 Compare September 11, 2024 16:14
@AhmedSoliman AhmedSoliman marked this pull request as ready for review September 11, 2024 16:14
Copy link

github-actions bot commented Sep 11, 2024

Test Results

15 files  +10  15 suites  +10   21m 36s ⏱️ + 19m 20s
 6 tests  - 36   6 ✅  - 36  0 💤 ±0  0 ❌ ±0 
18 runs   - 86  18 ✅  - 86  0 💤 ±0  0 ❌ ±0 

Results for commit 8eda441. ± Comparison against base commit eb5e849.

This pull request removes 42 and adds 6 tests. Note that renamed tests count towards both.
dev.restate.sdktesting.tests.AwaitTimeout ‑ timeout(Client)
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[1]
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[2]
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[3]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[1]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[2]
dev.restate.sdktesting.tests.CancelInvocation ‑ cancelInvocation(BlockingOperation, Client, URL)[3]
dev.restate.sdktesting.tests.Ingress ‑ headersPassThrough(Client)
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeSend(Client)
dev.restate.sdktesting.tests.Ingress ‑ idempotentInvokeService(Client)
…
dev.restate.e2e.JavaAwakeableTest ‑ generate(Client)
dev.restate.e2e.KtInterpreterTest ‑ simple(int)
dev.restate.e2e.NodeAwakeableTest ‑ generate(Client)
dev.restate.e2e.NodeInterpreterTest ‑ simple(int)
dev.restate.e2e.RetryOnUnknownServiceTest ‑ retryOnUnknownServiceUsingCall(Client, URL)
dev.restate.e2e.RetryOnUnknownServiceTest ‑ retryOnUnknownServiceUsingOneWayCall(Client, URL)

♻️ This comment has been updated with latest results.

Also, this introduces a mechanism to subscribe to connection closed events via ConnectionSender
@AhmedSoliman AhmedSoliman merged commit edd4657 into main Sep 17, 2024
19 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1957 branch September 17, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants