Update docker.yml to optionally push to DockerHub #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the docker.yml to optionally push the generated Docker image to DockerHub. It also updates the release.yml to enable this feature when creating releases. This fixes #909.
slinkydeveloper
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Two considerations:
- For the e2e tests, I guess we continue to use the images we publish on ghcr.io right? I prefer to do that, because we might hit the anonymous download quota from docker hub otherwise.
- Can you open an issue to update the image used in java sdk sdk-testing when we perform the next release?
Nice! |
tillrohrmann
force-pushed
the
issue#909
branch
from
1d32424 to
dfa88bc
Compare
tillrohrmann
force-pushed
the
issue#909
branch
from
dfa88bc to
929270c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the docker.yml to optionally push the generated Docker image to DockerHub. It also updates the release.yml to enable this feature when creating releases.
This fixes #909.