Don't try to handle Error (#376)

restatedev · Sep 9, 2024 · dea6bae · dea6bae
1 parent b28f7da
commit dea6bae
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 14 deletions.
diff --git a/sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/ContextImpl.kt b/sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/ContextImpl.kt
@@ -173,8 +173,6 @@ internal class ContextImpl internal constructor(private val syscalls: Syscalls)
       actionReturnValue = block()
     } catch (e: TerminalException) {
       actionFailure = e
-    } catch (e: Error) {
-      throw e
     } catch (t: Throwable) {
       syscalls.fail(t)
       throw CancellationException("Side effect failure", t)

diff --git a/sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/HandlerRunner.kt b/sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/HandlerRunner.kt
@@ -63,8 +63,6 @@ internal constructor(
         val req: REQ
         try {
           req = handlerSpecification.requestSerde.deserialize(syscalls.request().bodyBuffer())
-        } catch (e: Error) {
-          throw e
         } catch (e: Throwable) {
           LOG.warn("Error when deserializing input", e)
           throw TerminalException(
@@ -77,8 +75,6 @@ internal constructor(
         // Serialize output
         try {
           serializedResult = handlerSpecification.responseSerde.serializeToByteBuffer(res)
-        } catch (e: Error) {
-          throw e
         } catch (e: Throwable) {
           LOG.warn("Error when serializing input", e)
           throw TerminalException(

diff --git a/sdk-api/src/main/java/dev/restate/sdk/ContextImpl.java b/sdk-api/src/main/java/dev/restate/sdk/ContextImpl.java
@@ -168,8 +168,6 @@ public void onCancel(@Nullable Throwable t) {
       res = action.get();
     } catch (TerminalException e) {
       failure = e;
-    } catch (Error e) {
-      throw e;
     } catch (Throwable e) {
       syscalls.fail(e);
       AbortedExecutionException.sneakyThrow();

diff --git a/sdk-api/src/main/java/dev/restate/sdk/HandlerRunner.java b/sdk-api/src/main/java/dev/restate/sdk/HandlerRunner.java
@@ -69,8 +69,6 @@ public void run(
           try {
             req =
                 handlerSpecification.getRequestSerde().deserialize(syscalls.request().bodyBuffer());
-          } catch (Error e) {
-            throw e;
           } catch (Throwable e) {
             LOG.warn("Cannot deserialize input", e);
             callback.onCancel(
@@ -84,8 +82,6 @@ public void run(
           RES res;
           try {
             res = this.runner.apply(ctx, req);
-          } catch (Error e) {
-            throw e;
           } catch (Throwable e) {
             callback.onCancel(e);
             return;
@@ -95,8 +91,6 @@ public void run(
           ByteBuffer serializedResult;
           try {
             serializedResult = handlerSpecification.getResponseSerde().serializeToByteBuffer(res);
-          } catch (Error e) {
-            throw e;
           } catch (Throwable e) {
             LOG.warn("Cannot serialize output", e);
             callback.onCancel(