fix: adding support for providing list of values to all --id paramete…

…rs, i.e. `c8y inventory get --id 1111,2222` or `c8y alarms get --id 1111,2222`
reubenmiller · May 16, 2021 · 46fc97f · 46fc97f
1 parent cde8e4a
commit 46fc97f
Show file tree

Hide file tree

Showing 78 changed files with 437 additions and 190 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -65,20 +65,14 @@ None :)
 * set-session causes bad console wrapping when console is not wide enough
     * reduce message when width is not ok, or look at doing manual wrapping for
 
-* duplicate output when using c8y agents get --id name1,name2
 
-    ```sh
-    c8y agents create --name agent01
-    c8y agents create --name agent02
-    c8y agents get --id agent01,agent02 --select name -o csv
-    ```
-
-    Will return two output entries
+* Piping empty results has unexpected consequences
 
-    ```sh
-    agent01
-    agent01
     ```
+    c8y agents list | c8y alarms list --dry | c8y auditrecords list --dry
+    echo "{}" | c8y auditrecords list --dry
+    ```
+
 
 ~~not known~~
 ### Commands

diff --git a/api/spec/json/alarms.json b/api/spec/json/alarms.json
@@ -367,7 +367,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "pipeline": true,
           "required": true,
           "description": "Alarm id"
@@ -471,7 +471,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "pipeline": true,
           "description": "Alarm id",
           "required": true

diff --git a/api/spec/json/auditRecords.json b/api/spec/json/auditRecords.json
@@ -241,7 +241,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Audit id"

diff --git a/api/spec/json/binaries.json b/api/spec/json/binaries.json
@@ -93,7 +93,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Inventory binary id"
@@ -211,7 +211,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Inventory binary id"
@@ -260,7 +260,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Inventory binary id"

diff --git a/api/spec/json/bulkOperations.json b/api/spec/json/bulkOperations.json
@@ -85,7 +85,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Bulk Operation id"
@@ -126,7 +126,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Bulk Operation id"
@@ -273,7 +273,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "description": "Bulk Operation id",
           "pipeline": true,
           "required": true
@@ -329,7 +329,7 @@
       "queryParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "property": "bulkOperationId",
           "pipeline": true,
           "required": true,

diff --git a/api/spec/json/databroker.json b/api/spec/json/databroker.json
@@ -64,7 +64,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Data broker connector id"
@@ -100,7 +100,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Data broker connector id"

diff --git a/api/spec/json/deviceCredentials.json b/api/spec/json/deviceCredentials.json
@@ -75,7 +75,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "devicerequest",
+          "type": "[]devicerequest",
           "required": true,
           "pipeline": true,
           "description": "New Device Request ID"
@@ -113,7 +113,7 @@
       "body": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Device identifier. Max: 1000 characters. E.g. IMEI"
@@ -156,7 +156,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "devicerequest",
+          "type": "[]devicerequest",
           "required": true,
           "pipeline": true,
           "description": "Device identifier"
@@ -207,7 +207,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "devicerequest",
+          "type": "[]devicerequest",
           "required": true,
           "pipeline": true,
           "description": "New Device Request ID"
@@ -246,7 +246,7 @@
       "body": [
         {
           "name": "id",
-          "type": "devicerequest",
+          "type": "[]devicerequest",
           "required": true,
           "pipeline": true,
           "description": "Device identifier. Max: 1000 characters. E.g. IMEI"

diff --git a/api/spec/json/devicecontrol.json b/api/spec/json/devicecontrol.json
@@ -158,7 +158,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Operation id"
@@ -299,7 +299,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "description": "Operation id",
           "pipeline": true,
           "required": true

diff --git a/api/spec/json/events.json b/api/spec/json/events.json
@@ -197,7 +197,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Event id"
@@ -351,7 +351,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Event id"
@@ -399,7 +399,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Event id"
@@ -445,7 +445,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Event id"
@@ -489,7 +489,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Event id"
@@ -541,7 +541,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Event id"
@@ -600,7 +600,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Event id"

diff --git a/api/spec/json/inventory.json b/api/spec/json/inventory.json
@@ -338,7 +338,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "pipeline": true,
           "required": true,
           "description": "ManagedObject id"
@@ -410,7 +410,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "pipeline": true,
           "description": "ManagedObject id",
           "required": true
@@ -478,7 +478,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "pipeline": true,
           "required": true,
           "description": "ManagedObject id"

diff --git a/api/spec/json/inventoryAdditions.json b/api/spec/json/inventoryAdditions.json
@@ -58,7 +58,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "pipeline": true,
           "pipelineAliases": [
             "deviceId",
@@ -109,7 +109,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "property": "id",
           "required": true,
           "description": "Managed object id where the child addition will be added to",
@@ -165,7 +165,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "description": "Managed object id"
         },

diff --git a/api/spec/json/inventoryAssets.json b/api/spec/json/inventoryAssets.json
@@ -41,7 +41,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "pipelineAliases": [
@@ -206,9 +206,9 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
-          "required": true,
-          "description": "Asset id"
+          "type": "[]id",
+          "description": "Asset id",
+          "required": true
         },
         {
           "name": "child",

diff --git a/api/spec/json/measurements.json b/api/spec/json/measurements.json
@@ -318,7 +318,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Measurement id"
@@ -418,7 +418,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Measurement id"

diff --git a/api/spec/json/retentionRules.json b/api/spec/json/retentionRules.json
@@ -155,7 +155,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Retention rule id"
@@ -199,7 +199,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Retention rule id"
@@ -250,7 +250,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Retention rule id"

diff --git a/api/spec/json/users.json b/api/spec/json/users.json
@@ -62,7 +62,7 @@
       "pathParameters": [
         {
           "name": "id",
-          "type": "string",
+          "type": "[]id",
           "required": true,
           "pipeline": true,
           "description": "Role id. Note: lookup by name is not yet supported"
@@ -389,7 +389,7 @@
         },
         {
           "name": "id",
-          "type": "string",
+          "type": "[]user",
           "required": true,
           "pipeline": true,
           "description": "User id"