Fix API and parameterize port number #67
Conversation
empovit
force-pushed
the
openshift-4.17
branch
2 times, most recently
from
9213541 to
61b48b2
Compare
|
I'm not sure why the image build fails. I could successfully deploy the plugin on OCP 4.17 after just changing the deployment YAMLs. |
empovit
force-pushed
the
openshift-4.17
branch
from
61b48b2 to
2f4e7e8
Compare
Updated the Dockerfile, built and deployed an image. Everything looks fine. |
|
/lgtm |
|
@mareklibra @rawagner could you PTAL whenever possible? |
The console plugin API has been made GA quite a few OpenShift versions back (in OCP 4.12). * Update the API version to make the plugin work on newer versions of OpenShift. * Makes the port number a variable. * Bump the Helm chart version. * Update the image build. * Update the documentation.
empovit
force-pushed
the
openshift-4.17
branch
from
2f4e7e8 to
f39ee29
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: empovit, fabiendupont, mareklibra, mresvanis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit eb3e36f
into
rh-ecosystem-edge:main
| kind: ConsolePlugin | ||
| metadata: | ||
| name: {{ include "console-plugin-nvidia-gpu.fullname" . }} | ||
| namespace: {{ .Release.Namespace }} |
There was a problem hiding this comment.
FYI ConsolePlugin is a cluster-scoped resource so specifying namespace does nothing. Not a big deal though
There was a problem hiding this comment.
Hmmm, you're right! I added it because of https://github.com/openshift/console-plugin-template/blob/main/charts/openshift-console-plugin/templates/consoleplugin.yaml#L5. That template plugin is the recommended way for developing a console plugin, according to https://docs.openshift.com/container-platform/4.17/web_console/dynamic-plugin/dynamic-plugins-get-started.html. Will open an issue for them.
The console plugin API has been made GA quite a few OpenShift versions back (in OCP 4.12).
This PR updates the API version to make the plugin work on newer versions of OpenShift,
makes the port number a variable, and fixes the build.