Implement explicit context objects instead of cache scopes #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardsheridan
force-pushed
the
explicit_context
branch
from
244ebb9 to
cfc2f79
Compare
richardsheridan
force-pushed
the
explicit_context
branch
from
ae6c996 to
912770c
Compare
richardsheridan
force-pushed
the
explicit_context
branch
from
81ffeb3 to
21ae1fd
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would supersede #89. I don't really like the idea of juggling context objects but it does circumvent the need for
TreeVars. Then, later, if those are implemented in trio, it will be pretty trivial to reimplementcache_scope.