Skip to content

Commit

Permalink
Feature flags: Enable modern inspector
Browse files Browse the repository at this point in the history
Differential Revision: D54804534
  • Loading branch information
robhogan authored and facebook-github-bot committed Mar 28, 2024
1 parent 2af1da4 commit 3728956
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<c903b5aa8d70665c1104baa6670f8cb1>>
* @generated SignedSource<<4144a14f12d092ef5e6f98b54d5ddb36>>
*/

/**
Expand Down Expand Up @@ -43,9 +43,9 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi

override fun enableUIConsistency(): Boolean = false

override fun inspectorEnableCxxInspectorPackagerConnection(): Boolean = false
override fun inspectorEnableCxxInspectorPackagerConnection(): Boolean = true

override fun inspectorEnableModernCDPRegistry(): Boolean = false
override fun inspectorEnableModernCDPRegistry(): Boolean = true

override fun useModernRuntimeScheduler(): Boolean = false
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<9fd009411ce19224a3102d2713b0b042>>
* @generated SignedSource<<30ed120ea566c492b69310d3dbdbc0d2>>
*/

/**
Expand Down Expand Up @@ -68,11 +68,11 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider {
}

bool inspectorEnableCxxInspectorPackagerConnection() override {
return false;
return true;
}

bool inspectorEnableModernCDPRegistry() override {
return false;
return true;
}

bool useModernRuntimeScheduler() override {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@ const definitions: FeatureFlagDefinitions = {
'Ensures that JavaScript always has a consistent view of the state of the UI (e.g.: commits done in other threads are not immediately propagated to JS during its execution).',
},
inspectorEnableCxxInspectorPackagerConnection: {
defaultValue: false,
defaultValue: true,
description:
'Flag determining if the C++ implementation of InspectorPackagerConnection should be used instead of the per-platform one. This flag is global and should not be changed across React Host lifetimes.',
},
inspectorEnableModernCDPRegistry: {
defaultValue: false,
defaultValue: true,
description:
'Flag determining if the modern CDP backend should be enabled. This flag is global and should not be changed across React Host lifetimes.',
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<366b36d877532c93aa6e5a97b85edd06>>
* @generated SignedSource<<0b32023eeca560b015d00f5e9d896a95>>
* @flow strict-local
*/

Expand Down Expand Up @@ -138,11 +138,11 @@ export const enableUIConsistency: Getter<boolean> = createNativeFlagGetter('enab
/**
* Flag determining if the C++ implementation of InspectorPackagerConnection should be used instead of the per-platform one. This flag is global and should not be changed across React Host lifetimes.
*/
export const inspectorEnableCxxInspectorPackagerConnection: Getter<boolean> = createNativeFlagGetter('inspectorEnableCxxInspectorPackagerConnection', false);
export const inspectorEnableCxxInspectorPackagerConnection: Getter<boolean> = createNativeFlagGetter('inspectorEnableCxxInspectorPackagerConnection', true);
/**
* Flag determining if the modern CDP backend should be enabled. This flag is global and should not be changed across React Host lifetimes.
*/
export const inspectorEnableModernCDPRegistry: Getter<boolean> = createNativeFlagGetter('inspectorEnableModernCDPRegistry', false);
export const inspectorEnableModernCDPRegistry: Getter<boolean> = createNativeFlagGetter('inspectorEnableModernCDPRegistry', true);
/**
* When enabled, it uses the modern fork of RuntimeScheduler that allows scheduling tasks with priorities from any thread.
*/
Expand Down

0 comments on commit 3728956

Please sign in to comment.