Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inference slicer batching #1239

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

LinasKo
Copy link
Contributor

@LinasKo LinasKo commented May 28, 2024

Description

PR for inference slicer with batching. If batch_size is set, collections of slices are passed to the model.
Note that user need to define a callback that can accept list of images.

Still using threads if worker_threads > 1 (both batches and threads can be used simultaneously)

Previous PR, auto-closed during rewrite: #1108

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

https://colab.research.google.com/drive/1cfqBss7n-jc6VyKdjJ1AN9TnOBjdYQwZ?usp=sharing

Any specific deployment considerations

Docs

  • Docs updated? What were the changes:

@LinasKo LinasKo mentioned this pull request May 28, 2024
2 tasks
@LinasKo LinasKo requested a review from SkalskiP June 19, 2024 11:14
@CLAassistant
Copy link

CLAassistant commented Jul 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LinasKo
❌ Linas Kondrackis


Linas Kondrackis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LinasKo
Copy link
Contributor Author

LinasKo commented Jul 12, 2024

I've seen multiple CLA-related updates just now. Let's sort it out when I'm back from my trip.

P.S. It may also be due to me changing my github email a week ago.

@LinasKo
Copy link
Contributor Author

LinasKo commented Oct 30, 2024

Issues with threading: #1632

@roversch
Copy link

Hey this is great! Works out of the box.

Can we merge this plz? I now have to copy pasta it into the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants