Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump pydantic dependency to 2.9+ #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: bump pydantic dependency to 2.9+ #27

wants to merge 3 commits into from

Conversation

nherment
Copy link

@nherment nherment commented Oct 16, 2024 •
edited
Loading

This PR:

  • Widens the dependency on pydantic from ^1.8.1 to >=1.8.1, <3
  • Freezes dependency against prometheus-api-client to 0.5.3 as 0.5.5 has some api change incompatible with current code. I did not check 0.5.4.

I want to bump the dependency of pydantic so that we can use an updated version (v2.x) in the robusta code base.

There are 3 dependencies of pydantic in this repo, none of which have changed from pydantic 1.x to 2.x:

  • BaseModel
  • SecretStr
  • ValidationError

@nherment nherment requested a review from Avi-Robusta October 16, 2024 13:34
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nherment nherment marked this pull request as ready for review October 17, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avi-Robusta Avi-Robusta Awaiting requested review from Avi-Robusta

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nherment @CLAassistant