Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve path fixes for Alldebrid & only apply them to Alldebrid #652

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Sculas
Copy link
Contributor

@Sculas Sculas commented Jan 6, 2025

Fixes #648 🎉

@Cucumberrbob
Copy link

Yep - I'm happy 38z3bc1 fixes the issues - TestMultiple works as expected, as do all the single file torrents, including those in subdirectories, and those that had name mismatches before the webDAV change today.

Fantastic work! Thank you so much for all the time you've given

@Sculas Sculas changed the title fix: Only apply AllDebrid-specific path fixes to AllDebrid fix: Improve path fixes for Alldebrid (and only applies them to Alldebrid torrents) Jan 7, 2025
@Sculas Sculas changed the title fix: Improve path fixes for Alldebrid (and only applies them to Alldebrid torrents) fix: Improve path fixes for Alldebrid & only apply them to Alldebrid Jan 7, 2025
@TEALC82
Copy link

TEALC82 commented Jan 7, 2025

docker image pliz ?

@Cucumberrbob
Copy link

@TEALC82 PR comments probably aren't the place for this - it's best to leave these comments as uncluttered as possible.

To build the docker image yourself, clone Sculas' fork, git checkout fix/path-single-torrent-file, edit the Dockerfile to match my PR (without this, you'll just build rogerfar/rdt-client/master), and then you can run docker build --tag rdtclient .. Then make sure you use that rdtclient image tag for your container

@TEALC82
Copy link

TEALC82 commented Jan 8, 2025

Thanks for the PR, the downloads work fine but RDT sends a "bad path" to my arr, it adds a "/" after the file name. If I do the import manually, there is no problem.

Import failed, path does not exist or is not accessible by Sonarr: /home/(removed)/Download/sonarr/Unnamed Memory S02E01 VOSTFR 1080p WEB x264 AAC -Tsundere-Raws (CR).mkv/. Ensure the path exists and the user running Sonarr has the correct permissions to access this file/folder

@Cucumberrbob
Copy link

You are 100% right - I should have tested with *arr rather than just saying "yep those symlinks look good, this is fixed"

Looks like the issue is here:

torrentPath = Path.Combine(downloadPath, torrent.RdName) + Path.DirectorySeparatorChar;

All we need to do is not include that DirectorySeparatorChar when the torrent is an AD single-file torrent. qBit's API docs say that content_path should be the "Absolute path of [the] torrent['s] content (root path for multifile torrents, absolute file path for singlefile torrents)"

@Sculas
Copy link
Contributor Author

Sculas commented Jan 8, 2025

@Cucumberrbob Something like that? d6305c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alldebrid puts files in silly places sometimes, causing rdt-client to be unable to find them
3 participants