Skip to content

Commit

Permalink
Disable tests for ActiveSupport::Notifications and Rails log subscrib…
Browse files Browse the repository at this point in the history
…er specs

ActiveSupport fails to load at this moment on 3.4
  • Loading branch information
flash-gordon committed Dec 25, 2024
1 parent 9ff57d6 commit f2d870c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

include_context "users"

it "works" do
xit "works" do
container.gateways[:default].use_logger(LOGGER)

sql = nil
Expand Down
13 changes: 9 additions & 4 deletions spec/integration/support/rails_log_subscriber_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,19 @@

require "spec_helper"

require "active_support/log_subscriber/test_helper"

RSpec.describe "Rails log subscriber", :postgres, seeds: false do
before(:all) do
require "active_support/log_subscriber/test_helper"
rescue LoadError
end

before do
ROM::SQL.load_extensions(:active_support_notifications, :rails_log_subscriber)
end

include ActiveSupport::LogSubscriber::TestHelper
if defined?(ActiveSupport::LogSubscriber::TestHelper)
include ActiveSupport::LogSubscriber::TestHelper
end

include_context "users"

Expand All @@ -24,7 +29,7 @@
container.gateways[:default].use_logger(logger)
end

it "works" do
xit "works" do
conn.run(test_query)

expect(logger.logged(:debug).last).to include(test_query)
Expand Down

0 comments on commit f2d870c

Please sign in to comment.