Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
…into 4739-fix-product-drive-delete
  • Loading branch information
MichaScant committed Jan 6, 2025
2 parents 83976b7 + 261e063 commit ea47123
Show file tree
Hide file tree
Showing 81 changed files with 579 additions and 359 deletions.
34 changes: 10 additions & 24 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ inherit_mode:

inherit_gem:
standard: config/base.yml
standard-rails: config/base.yml
standard-performance: config/base.yml

inherit_from:
.rubocop_todo.yml
Expand All @@ -12,15 +14,17 @@ require:
- rubocop-rails
- rubocop-performance
- standard
- standard-rails
- standard-performance

AllCops:
TargetRubyVersion: 3.1.2
Exclude:
- "vendor/**/*"
- "db/schema.rb"
- "db/partners_schema.rb"
- "db/seeds.rb"
- "db/migrate/*"
- "db/partners_migrate/*"
- "bin/*"
- "lib/files/cucumber.rake"
- "lib/tasks/*"
Expand All @@ -29,26 +33,13 @@ AllCops:
- "Rakefile"
- "tmp/*"
- "node_modules/**/*"
UseCache: false

Rails:
Enabled: true
Rails/Output:
Enabled: true
Rails/Date:
Enabled: true
Rails/FilePath:
Enabled: false
Rails/FindBy:
Enabled: true
Rails/FindEach:
Enabled: true
Rails/PluralizationGrammar:
Enabled: true
Rails/ScopeArgs:
Enabled: true
Rails/TimeZone:
Enabled: true
Rails/UnknownEnv:
Environments:
- production
Expand All @@ -62,32 +53,27 @@ Rails/AfterCommitOverride:
Enabled: false
Rails/FindById:
Enabled: false
Rails/Inquiry:
Enabled: false
Rails/MailerName:
Enabled: false
Rails/MatchRoute:
Enabled: false
Rails/NegateInclude:
Enabled: false
Rails/Pluck:
Enabled: false
Rails/PluckInWhere:
Enabled: false
Rails/RenderInline:
Enabled: false
Rails/RenderPlainText:
Enabled: false
Rails/ShortI18n:
Enabled: false
Rails/SquishedSQLHeredocs:
Enabled: false
Rails/WhereExists:
Enabled: false
Rails/WhereNot:
Enabled: false
Rails/HasAndBelongsToMany:
Enabled: false
Rails/ThreeStateBooleanColumn:
Enabled: true
# FIXME: Fix our ENV variable access and remove the following config.
Rails/EnvironmentVariableAccess:
AllowReads: true

Rails/BulkChangeTable:
Exclude:
Expand Down
6 changes: 4 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,16 @@ group :development, :test do
# Debugger which supports rdbg and Shopify Ruby LSP VSCode extension
gem "debug", ">= 1.0.0"
# RSpec behavioral testing framework for Rails.
gem "rspec-rails", "~> 7.0.1"
gem "rspec-rails", "~> 7.1.0"
# Static analysis / linter.
gem "rubocop"
# Rails add-on for static analysis.
gem 'rubocop-performance'
gem "rubocop-rails", "~> 2.25.1"
# Default rules for Rubocop.
gem "standard", "~> 1.40"
gem "standard-rails"
gem "standard-performance"
# Erb linter.
gem "erb_lint"
end
Expand Down Expand Up @@ -219,4 +221,4 @@ end
# Use Redis for Action Cable
gem "redis", "~> 5.3"

gem "importmap-rails", "~> 2.0"
gem "importmap-rails", "~> 2.1"
Loading

0 comments on commit ea47123

Please sign in to comment.