Fix partner view to display distribution scheduled date #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coalest
reviewed
Dec 16, 2024
| @@ -317,6 +317,21 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| context "when viewing prior distributions" do | |||
There was a problem hiding this comment.
Since this test doesn't require any browser interactivity/javascript, it could probably be changed from a system spec to be a request spec. Because system specs are pretty slow.
There was a problem hiding this comment.
FWIW, I guarantee @dorner will strongly suggest the same thing.
There was a problem hiding this comment.
Indeed. 😁 Can it please be moved to a request spec?
|
LGTM from a functional POV |
dorner
requested changes
Dec 18, 2024
| @@ -317,6 +317,21 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| context "when viewing prior distributions" do | |||
There was a problem hiding this comment.
Indeed. 😁 Can it please be moved to a request spec?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4856
Description
Previously, the partner view's "prior distributions" section included the date when distributions were entered into the system. Now, the "prior distributions" section will instead include the distribution scheduled date.
Type of change
How Has This Been Tested?
Screenshots
Before
After