Fix typos with source code spell checker #4871

coalest · 2024-12-19T16:56:20Z

Doesn't resolve any issue.

Description

I noticed a typo in a css class (prioirty instead of priority), which got me thinking maybe there are other typos in our code base.

So I found typos (a source code spell checker) and ran it on our code base. Turns out "essentials" is really hard to spell :D

Most of the typos are in comments, but some are in code so we probably need to do some manual testing here.

Type of change

Updates our documentation, but also probably some bug fixes as well (at least two places were the css classes will be different than before).

How Has This Been Tested?

Not much really

Bumps [redis](https://github.com/redis/redis-rb) from 5.2.0 to 5.3.0. - [Changelog](https://github.com/redis/redis-rb/blob/master/CHANGELOG.md) - [Commits](redis/redis-rb@v5.2.0...v5.3.0) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Brock Wilcox <[email protected]>

…m Categories changes to a yes/no! Obviously wrong! (#4668) * fix(partner_groups_controller): assign item_categories when create or edit params are invalid * fix: typo

Bumps [puma](https://github.com/puma/puma) from 6.4.2 to 6.4.3. - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v6.4.2...v6.4.3) --- updated-dependencies: - dependency-name: puma dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove filtering for active attribute on children query * Add spec that tests for child item requests

…-status Change State to Status on Distribution Table

Add partner group to organization. Add new partner for seed

* validate the presence of business name for a vendor add validation for business name on vendor model, skip validation in provideable when the model is a vendor to prevent duplicate errors on invalid form submission, specs for both changes * create migration to update a vendor's business name to its contact name if business name is blank * move product drive participant validations out of provideable and into model instead of skipping when the provideable model is vendor * fix arg name

* Change button from 'Promote to Admin' to 'Edit User' * Replace system spec with request spec for link for editing user * Replace system spec with request spec for link for editing user

…n beside Add a Partner link. Add system tests to ensure the Partner cta section has 2 links. (#4710) Co-authored-by: Athira Kadampatta <[email protected]>

# Conflicts: # app/controllers/distributions_controller.rb # spec/rails_helper.rb

* Add view password functionality to login form * refactored the password visiblity toggle into a Stimulus controller

user docs cont v: draft inventory section of user guide

User docs cont vi: draft exports section of user guide

Fix inventory seeding for storage location from donations

- rename service class - update test specs - update report name

cielf · 2024-12-19T18:49:35Z

app/views/admin/organizations/index.html.erb

Just noting the ones that look like they could have an effect on behaviour at this time. This one.

cielf · 2024-12-19T18:50:15Z

app/views/distributions/show.html.erb

cielf · 2024-12-19T18:51:58Z

app/views/partner_groups/_form.html.erb

cielf · 2024-12-19T18:52:17Z

app/views/partners/_form.html.erb

cielf · 2024-12-19T18:54:08Z

app/views/partners/families/index.html.erb

should be better if anything

cielf · 2024-12-19T18:55:30Z

spec/fixtures/files/partners_with_bom_encoding.csv

Not sure what this does, but it's in a spec.

Those look like plausibly real emails, though.

* Fix flaky family requests system spec * Fix flaky system partners children spec

…to 6.5.0 (#4813) * build(deps-dev): bump factory_bot_rails from 6.4.3 to 6.4.4 Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.4.3 to 6.4.4. - [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases) - [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md) - [Commits](thoughtbot/factory_bot_rails@v6.4.3...v6.4.4) --- updated-dependencies: - dependency-name: factory_bot_rails dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Fix merge conflicts with main * Update puma to 6.5.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Orner <[email protected]> Co-authored-by: Brock Wilcox <[email protected]> Co-authored-by: Cory Streiff <[email protected]>

We were saving a new distribution (which causes a redirect to that distribution's show page) and then immediately clicking on the distributions index page (which redirects as well). This introduced a race condition that was flaky when we tried to click a link that didn't exist on the page.

We were expecting the `family_zipcodes_list` to have a certain order but no order is guaranteed in the request.

* lowered pagination threshold in dev and staging using kaminari * Trigger Build

…4873) * Data Fix re started reqeusts that were actually fulfilled * Data Fix re started reqeusts that were actually fulfilled

* build(deps-dev): bump rubocop from 1.65.1 to 1.68.0 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.65.1 to 1.68.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.65.1...v1.68.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update rubocop * Fix linting --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Orner <[email protected]> Co-authored-by: Brock Wilcox <[email protected]> Co-authored-by: Cory Streiff <[email protected]> Co-authored-by: Cory Streiff <[email protected]>

…y-report-performance Perf: refactor DistributionsByCountry#report using raw SQL query

cielf · 2024-12-20T20:17:04Z

There is one thing here that I want to talk to the planning group about. Not that the change couldn't happen, but whether that text should be in the system where it is.

cielf

Here's the status -- I've tested the ones that looked possible to change behaviour other than actually spelling on the page. One of them did, in a negative way (shifted the button to a weird place), and should be either addressed or rolled back.

I also want to bring the situation of the real emails to the planning meeting. Should that stop this from going in? Probably not, as they are already there.

app/views/admin/organizations/index.html.erb

cielf · 2024-12-21T14:05:36Z

app/views/distributions/show.html.erb

cielf · 2024-12-21T14:13:15Z

app/views/partners/_form.html.erb

cielf · 2024-12-21T14:19:24Z

app/views/partners/families/index.html.erb

cielf

I don't see any remaining issues that are related to the changes. @dorner -- most of these are innocuous, but could you have a quick browse-through to confirm?

norrismei and others added 30 commits October 4, 2024 11:05

Remove pick_up_person trait

96e6494

Merge branch 'main' into 4406-add-print-picklists

da73e52

draft inventory section

dd128f1

4655: [BUG] If you have an error on entering a partner group, the Ite…

56f2aaf

…m Categories changes to a yes/no! Obviously wrong! (#4668) * fix(partner_groups_controller): assign item_categories when create or edit params are invalid * fix: typo

4516 fix child requests for inactive children (#4699)

e25930a

* Remove filtering for active attribute on children query * Add spec that tests for child item requests

Merge pull request #4670 from lit-poks/fix/distribution-enum-state-to…

2167ecc

…-status Change State to Status on Distribution Table

Add partner group to organization. Add new partner for seed

b66bda3

add new partner Second Street Community Outreach to group 2

7063c25

update additional partner group in contributing.md

7c976f0

Atleast one inactive item in an organization

a915cf2

4672-Header-Alignment-on-all-things

6e35a45

Merge pull request #4708 from lit-poks/seeds/partner-group-2

fc3ee6e

Add partner group to organization. Add new partner for seed

Add annotation to rendered views for easier development (#4709)

05894c9

Change button from 'Promote to Admin' to 'Edit User' (#4701)

2560e98

* Change button from 'Promote to Admin' to 'Edit User' * Replace system spec with request spec for link for editing user * Replace system spec with request spec for link for editing user

Add a link to Import Partners on the dashboard getting started sectio…

89ee8a0

…n beside Add a Partner link. Add system tests to ensure the Partner cta section has 2 links. (#4710) Co-authored-by: Athira Kadampatta <[email protected]>

Merge branch 'main' into 4333-remove-inventory-items

5d71eba

# Conflicts: # app/controllers/distributions_controller.rb # spec/rails_helper.rb

Add view password functionality to login form (#4714)

ca7cdda

* Add view password functionality to login form * refactored the password visiblity toggle into a Stimulus controller

Add items method

aceff78

fixes

d030133

more fixes

6a79219

exports

114d740

Merge branch 'rubyforgood:main' into main

3c744e7

Merge pull request #4706 from cielf/user-docs-cont-v

759ad52

user docs cont v: draft inventory section of user guide

Merge pull request #4718 from cielf/user-docs-cont-vi

d9bf0f1

User docs cont vi: draft exports section of user guide

Inactive item and discarded storage location to have 0 inventory

474cff5

Fix inventory seeding for storage location from donations

Merge branch 'main' into seed/inactive-location-and-items

cd694ba

renames diaper acquisition to diapers

2adf967

- rename service class - update test specs - update report name

Fix spec after typo fix

34a2d27

cielf reviewed Dec 19, 2024

View reviewed changes

app/views/partner_groups/_form.html.erb Outdated

Copy link

Collaborator

cielf Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one

cielf reviewed Dec 19, 2024

View reviewed changes

coalest and others added 13 commits December 19, 2024 18:52

Rename fixture_path to fixtures_path to fix deprecation warning (#4866)

9b9edc5

Fix flaky family requests system spec (#4867)

b53dd2e

* Fix flaky family requests system spec * Fix flaky system partners children spec

Remove duplicate donation system spec (#4863)

83703e9

Fix missing partner dropdown options of distribution update fail (#4868)

d653a42

Fix flaky partners requests request spec (#4870)

2b213f2

We were expecting the `family_zipcodes_list` to have a certain order but no order is guaranteed in the request.

lowered pagination threshold in dev and staging using kaminari (#4865)

9febed7

* lowered pagination threshold in dev and staging using kaminari * Trigger Build

Data fix mhm and aad request distribution link and fulfilled status (#…

483a402

…4873) * Data Fix re started reqeusts that were actually fulfilled * Data Fix re started reqeusts that were actually fulfilled

Perf: Refactor dashboard index page (#4874)

f9b076c

Fix flaky admin users system spec (#4875)

ffbcb61

Merge pull request #4841 from coalest/improve-distributions-by-countr…

34b66dd

…y-report-performance Perf: refactor DistributionsByCountry#report using raw SQL query

cielf requested changes Dec 21, 2024

View reviewed changes

coalest added 2 commits December 21, 2024 15:43

Fix add new organization button placement

73dd428

Merge branch 'main' into fix-typos-with-source-code-spell-checker

19d6519

coalest requested a review from cielf December 21, 2024 14:45

coalest force-pushed the fix-typos-with-source-code-spell-checker branch from a74ee99 to 19d6519 Compare December 21, 2024 15:44

coalest added 2 commits December 21, 2024 17:05

Add back filed removed from git history

1f1f7ec

Merge branch 'main' into fix-typos-with-source-code-spell-checker

5bd2ebf

cielf reviewed Dec 21, 2024

View reviewed changes

coalest closed this by deleting the head repository Dec 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix typos with source code spell checker #4871

Fix typos with source code spell checker #4871

coalest commented Dec 19, 2024 •

edited

Loading

cielf Dec 19, 2024

cielf Dec 19, 2024

cielf Dec 21, 2024

cielf Dec 19, 2024

cielf Dec 19, 2024

cielf Dec 21, 2024

cielf Dec 19, 2024

cielf Dec 21, 2024

cielf Dec 19, 2024

cielf Dec 19, 2024

cielf commented Dec 20, 2024

cielf left a comment

cielf Dec 21, 2024

cielf Dec 21, 2024

cielf Dec 21, 2024

cielf left a comment •

edited

Loading

Fix typos with source code spell checker #4871

Fix typos with source code spell checker #4871

Conversation

coalest commented Dec 19, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cielf commented Dec 20, 2024

cielf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cielf left a comment • edited Loading

Choose a reason for hiding this comment

coalest commented Dec 19, 2024 •

edited

Loading

cielf left a comment •

edited

Loading