Update Rubocop config #4877
Closed
Update Rubocop config #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add partner group to organization. Add new partner for seed
* validate the presence of business name for a vendor add validation for business name on vendor model, skip validation in provideable when the model is a vendor to prevent duplicate errors on invalid form submission, specs for both changes * create migration to update a vendor's business name to its contact name if business name is blank * move product drive participant validations out of provideable and into model instead of skipping when the provideable model is vendor * fix arg name
* Change button from 'Promote to Admin' to 'Edit User' * Replace system spec with request spec for link for editing user * Replace system spec with request spec for link for editing user
…n beside Add a Partner link. Add system tests to ensure the Partner cta section has 2 links. (#4710) Co-authored-by: Athira Kadampatta <[email protected]>
# Conflicts: # app/controllers/distributions_controller.rb # spec/rails_helper.rb
* Add view password functionality to login form * refactored the password visiblity toggle into a Stimulus controller
user docs cont v: draft inventory section of user guide
User docs cont vi: draft exports section of user guide
Fix inventory seeding for storage location from donations
- rename service class - update test specs - update report name
Add feature to print unfulfilled requests as a picklists PDF
* Fix flaky family requests system spec * Fix flaky system partners children spec
…to 6.5.0 (#4813) * build(deps-dev): bump factory_bot_rails from 6.4.3 to 6.4.4 Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 6.4.3 to 6.4.4. - [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases) - [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/main/NEWS.md) - [Commits](thoughtbot/factory_bot_rails@v6.4.3...v6.4.4) --- updated-dependencies: - dependency-name: factory_bot_rails dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Fix merge conflicts with main * Update puma to 6.5.0 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Orner <[email protected]> Co-authored-by: Brock Wilcox <[email protected]> Co-authored-by: Cory Streiff <[email protected]>
We were saving a new distribution (which causes a redirect to that distribution's show page) and then immediately clicking on the distributions index page (which redirects as well). This introduced a race condition that was flaky when we tried to click a link that didn't exist on the page.
We were expecting the `family_zipcodes_list` to have a certain order but no order is guaranteed in the request.
* lowered pagination threshold in dev and staging using kaminari * Trigger Build
…4873) * Data Fix re started reqeusts that were actually fulfilled * Data Fix re started reqeusts that were actually fulfilled
* build(deps-dev): bump rubocop from 1.65.1 to 1.68.0 Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.65.1 to 1.68.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.65.1...v1.68.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update rubocop * Fix linting --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Orner <[email protected]> Co-authored-by: Brock Wilcox <[email protected]> Co-authored-by: Cory Streiff <[email protected]> Co-authored-by: Cory Streiff <[email protected]>
…y-report-performance Perf: refactor DistributionsByCountry#report using raw SQL query
coalest
commented
Dec 21, 2024
| @@ -174,9 +174,11 @@ def self.capybara_tmp_path | |||
| Faker::UniqueGenerator.clear # Clears used values to avoid retry limit exceeded error | |||
| end | |||
|
|
|||
| # rubocop:disable Rails/RedundantTravelBack | |||
There was a problem hiding this comment.
In theory we shouldn't need this line as Rails supposedly since 5.2 automatically runs travel_back after every test.
In practice, lots of tests fail due to time related issues if we remove these lines,
coalest
force-pushed
the
Update-rubocop-config
branch
from
13db92d to
1ff33fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue.
Description
Whenever you run
bin/lintyou get this long list of cops that have been added but not configured by our Rubocop config:. Let's use standard-rails and standard-performance to apply those cops.
Also let's turn on caching so that linting is faster.
Type of change
How Has This Been Tested?
Test suite