Mailer: Email to announce MFA is required for maintainers of gems with 180M+ downloads #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
bettymakes
force-pushed
the
mfa-mailer-phase3-launch
branch
2 times, most recently
from
4180e88 to
1114743
Compare
bettymakes
commented
Aug 11, 2022
Rake task triggers a mailer which will be sent to users who are owners of at least one gem with 180M+ downloads, and have not yet enabled MFA, or have MFA set to 'ui_only'.
bettymakes
force-pushed
the
mfa-mailer-phase3-launch
branch
2 times, most recently
from
d2f92c5 to
0302581
Compare
jenshenny
reviewed
Aug 12, 2022
bettymakes
force-pushed
the
mfa-mailer-phase3-launch
branch
6 times, most recently
from
cc20270 to
d3fe58f
Compare
sonalkr132
reviewed
Aug 15, 2022
app/views/mailer/mfa_required_popular_gems_announcement.html.erb
Outdated
Show resolved
Hide resolved
Extract conditional strings to a helper. This resolves Code Climate violation on repetitive code blocks and tidies up the mailer actions.
Per Aditya: > It is not clear what will be further disruptions. > Disabling these operations was the final thing.
bettymakes
force-pushed
the
mfa-mailer-phase3-launch
branch
from
d3fe58f to
5f0d130
Compare
sonalkr132
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤷♀️ What problem are you solving?
Contributes to https://github.com/Shopify/ruby-conventions/issues/137
Closes #3165
We need to send out an email on August 15, 2022 to notify maintainers of gems with 180M+ downloads that MFA enforcement is now in effect. Similar to the reminder email, this mailer continues with a targeted approach. It's only being sent to impacted users who have not yet enabled MFA (
disabled), or have weak MFA enabled (ui_only).📋 How will you solve this?
🔹 Create a mailer
mfa_required_popular_gems_announcementand a mailer view in bothHTMLandplain textformatsdisabled)ui_only)🔹 Add rake task for delivering the email
August 15, 2022to send out this announcementrake mfa_policy:announce_enforcement_for_popular_gems🔹 Set up mailer preview
🎩 Tophat instructions / Acceptance Testing
Below are the instructions for trying this out yourself:
📧 To preview the email:
rails s) ...http://localhost:3000/rails/mailers) to review the list of all mailers available for previewmfa_required_popular_gems_announcementhttp://localhost:3000/rails/mailers/mailer/mfa_required_soon_announcement👤 To change the user:
MailerPreview#mfa_required_popular_gems_announcement.User.last.idwith a different user (e.g.User.first)👀 Email versions
🚫 Email for users with MFA disabled
🤞 Email for users with MFA enabled (
ui_only) -- weak MFA