Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avm1: Try calling properties on root if the current scope isn't callable #18885

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ydalton
Copy link
Contributor

@ydalton ydalton commented Dec 6, 2024

Redo of #18827, I did a thing (put the commit on a topic branch on master, then discarded the extra commits on main) and it auto-closed my PR.

Thanks to @Herschel for the fix, and @Dinnerbone for suggesting the
commit message.

In the final boss of Super Mario 63, Mario hangs in the air, and thus
cannot complete this battle and finish the game. This commit fixes that
bug. See issue ruffle-rs#10582 for the technical details.

Closes: ruffle-rs#10582

Co-authored-by: Mike Welsh <[email protected]>
@kjarosh kjarosh added A-avm1 Area: AVM1 (ActionScript 1 & 2) T-fix Type: Bug fix (in something that's supposed to work already) labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2) T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants