Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not manually map numeric error #13

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Do not manually map numeric error #13

merged 1 commit into from
Nov 28, 2024

Conversation

tcharding
Copy link
Member

We provide From impls for all errors that include a NumericError - use it.

apoelstra
apoelstra approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 93af3a8; successfully ran local tests

@apoelstra apoelstra merged commit b32b8ee into rust-bitcoin:master Nov 28, 2024
32 checks passed
@tcharding tcharding deleted the 11-28-rm-manual-map branch November 28, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcharding @apoelstra