Add system theme setting #1448
Merged
Add system theme setting #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system setting is followed if there is no item `blog-rust-lang-org-theme` in local storage. In order to switch back to the system theme, that item is deleted. Previously, if a system preference for dark theme was detected, that was additionally stored explicitly as `blog-rust-lang-org-theme`. That was removed, because it prevents the system setting from being followed if the user switches their system back to light theme.
Merged
senekor
commented
Dec 26, 2024
GuillaumeGomez
approved these changes
Dec 26, 2024
|
Code looks good to me, thanks! |
|
They both seem to work together correctly. This one adds the possibility to reset back to "system settings" whereas the other fixes a bug due to script loading order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system setting is followed if there is no item
blog-rust-lang-org-themein local storage. In order to switch back to the system theme, that item is deleted.Previously, if a system preference for dark theme was detected, that was additionally stored explicitly as
blog-rust-lang-org-theme. That was removed, because it prevents the system setting from being followed if the user switches their system back to light theme.