Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't suggest to use cloned for Cow in unnecessary_to_owned #13853

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't suggest to use cloned for Cow in unnecessary_to_owned #13853

wants to merge 1 commit into from

Conversation

lapla-cogito
Copy link
Contributor

fix #13624

changelog: [unnecessary_to_owned]: don't suggest to use cloned on Cow in unnecessary_to_owned

@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 19, 2024
@lapla-cogito lapla-cogito force-pushed the into_owned_cow branch 3 times, most recently from 461c834 to e0bf121 Compare December 19, 2024 13:40
@alex-semenyuk
Copy link
Member

@lapla-cogito Could you please take a look failed tests

@lapla-cogito lapla-cogito force-pushed the into_owned_cow branch 3 times, most recently from cbccedb to 9bcfac6 Compare December 27, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y21 y21 y21 left review comments

Assignees

@y21 y21

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive: cow and into_owned
4 participants
@lapla-cogito @rustbot @alex-semenyuk @y21