Initial impl of raw_assign_to_drop
#13866
Open
+167
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4294
The lint simply checks all assignments via unsafe pointers where to dereferenced-type has drop-glue.
I'm somewhat unsure about what to call this thing - is it
assign_raw_ptr_using_drop
,raw_assign_drop
,dropped_assign_raw
, ... ?Although some of the tests involve
&mut as *mut
, the lint does not make efforts to filter out situations where the raw pointer is derived from a known-safe source. The general assumption is that if we have a raw pointer at at all, and assign to the place behind the pointer, then all safety bets are off anyway (otherwise, one could have assigned via&mut
to begin with).changelog: [
raw_assign_to_drop
]: Initial impl