Do not remove required parentheses in borrow_as_ptr suggestion
#13884
+45
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Timo has a lot of work, I'll reassign to myself the ones with no review yet. r? blyxyas |
blyxyas
approved these changes
Dec 29, 2024
| let operator_kind = match mutability { | ||
| Mutability::Not => "const", | ||
| Mutability::Mut => "mut", | ||
| }; | ||
| format!("&raw {operator_kind} {snip}") | ||
| let span = if has_enclosing_paren(snippet_with_applicability(cx, expr.span, "", &mut app)) { |
There was a problem hiding this comment.
Suggested change
| let span = if has_enclosing_paren(snippet_with_applicability(cx, expr.span, "", &mut app)) { | |
| // Make sure that the span to be replaced doesn't include parenthesis, that could break the suggestion. | |
| let span = if has_enclosing_paren(snippet_with_applicability(cx, expr.span, "", &mut app)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, simplify boolean shortcut expression, and ensure that applicability is properly applied, as it was ignored and
MachineApplicablewas always used.changelog: [
borrow_as_ptr]: do not remove required parentheses in autofix suggestionClose #13882