Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative times with languages support #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ohanhi
Copy link

@ohanhi ohanhi commented Jan 9, 2019

This is a bit of a daring PR out of the blue, so feel free to disagree with my decisions and/or point out issues I might not have noticed. I introduced a new module: DateFormat.Relative.Language. Then I moved the RelativeTimeOptions along with the default (now called english) to that module. Finally, I localized the relative time options for Finnish.

Because of the type moved from DateFormat.Relative to DateFormat.Relative.Language (to avoid circular imports), this change would be a major version. If you'd really like to avoid that, there's at least two ways to do it:

  1. expose the type through a dummy type alias MyType = Module.MyType, which can be confusing for people (which one do they need to import to be able to construct a record?)
  2. move the type back to the old place and keep an unexposed duplicate of the type in DateFormat.Relative.Language for type signature purposes

Note: This builds on #19, the first two commits are in common with it. 6181ece is where the actual changes happen.

@Punie Punie mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant