Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerability Updates and Handlebars.dll Update #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Vulnerability Updates and Handlebars.dll Update #181

wants to merge 1 commit into from

Conversation

an-d-uu
Copy link

@an-d-uu an-d-uu commented Nov 17, 2021

@an-d-uu
Vulnerability Updates
68bca38 
* Update backbone from  to 1.4.0 to correct Cross-site Scripting issue. (https://snyk.io/vuln/npm%3Abackbone)
* Update Handlebars.ddl from 1.10.1 to 1.11.5.
* Update handlebars.js from 4.0.5 to 4.7.7 to correct vulnerabilities. (https://snyk.io/test/npm/handlebars/4.0.5)
@robheffo79
Copy link

Just an FYI: I am running a local test build of OC with Handlebars 2.1.6 compiled into it. There were literally only 2 changes needed to make it work.

@Timo-Breumelhof
Copy link
Collaborator

Just an FYI: I am running a local test build of OC with Handlebars 2.1.6 compiled into it. There were literally only 2 changes needed to make it work.

Are the changes you made the same as the ones in this PR?

@an-d-uu
Copy link
Author

an-d-uu commented Jun 11, 2024

No, it was a very easy change to make this work. I believe at the time it was failing one of the automated tests, but you are right that there were only 2 changes to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@an-d-uu @robheffo79 @Timo-Breumelhof