Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: granular MUI imports #4603

Closed
wants to merge 1 commit into from
Closed

Refactor: granular MUI imports #4603

wants to merge 1 commit into from

Conversation

katspaugh
Copy link
Member

Experimental branch with granular MUI imports.

Copy link

github-actions bot commented Dec 4, 2024

Copy link

github-actions bot commented Dec 4, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1005.97 KB (-15 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 39.66 KB (🟡 +4 B) 1.02 MB
/apps/custom 37.74 KB (🟡 +3 B) 1.02 MB
/apps/open 53.68 KB (-2 B) 1.03 MB
/balances 37.57 KB (🟢 -5 B) 1.02 MB
/balances/nfts 17.53 KB (🟢 -3 B) 1023.5 KB
/bridge 2.57 KB (🟡 +3 B) 1008.54 KB
/home 58.73 KB (-4 B) 1.04 MB
/new-safe/advanced-create 36.79 KB (🟡 +24 B) 1.02 MB
/new-safe/create 35.88 KB (🟡 +24 B) 1.02 MB
/new-safe/load 16.32 KB (🟢 -2 B) 1022.29 KB
/settings/appearance 7.71 KB (🟢 -2 B) 1013.68 KB
/settings/data 7.22 KB (🟢 -1 B) 1013.19 KB
/settings/environment-variables 8.79 KB (🟡 +1 B) 1014.76 KB
/settings/modules 9.48 KB (🟡 +5 B) 1015.45 KB
/settings/notifications 26.82 KB (🟢 -7 B) 1.01 MB
/settings/safe-apps 23.17 KB (🟢 -3 B) 1.01 MB
/settings/setup 46.26 KB (🟢 -9 B) 1.03 MB
/share/safe-app 9.16 KB (🟡 +5 B) 1015.13 KB
/transactions 109.97 KB (-10 B) 1.09 MB
/transactions/history 109.92 KB (-10 B) 1.09 MB
/transactions/msg 54.68 KB (-1 B) 1.04 MB
/transactions/queue 52.92 KB (🟢 -10 B) 1.03 MB
/transactions/tx 46.84 KB (🟢 -6 B) 1.03 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Dec 4, 2024

Coverage report

Action wasn't able to generate report within GitHub comment limit. If you're facing this issue, please let me know by commenting under this issue.

Report generated by 🧪jest coverage report action from 9df9496

@katspaugh katspaugh closed this Dec 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant