fix(plasma-core, plasma-hope): Add promise resolve for forceUpdate method in Popup and Tooltip components
#554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p` and `Tooltip` components
neretin-trike
force-pushed
the
neretinaaa/fix-force-update-popper
branch
from
9e76cb4 to
809ce86
Compare
|
Theme Builder app deployed! http://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-554/ |
neretin-trike
changed the title
Popup and Tooltip componentsPopup and Tooltip components
|
Documentation preview deployed! website: http://plasma.sberdevices.ru/pr/pr-554/ |
Yakutoc
reviewed
Jun 8, 2023
|
Component performance testing Result: 🟢 Success Check out report in job artifacts! |
Yakutoc
reviewed
Jun 8, 2023
| * Данный хак, нужен для того, чтобы это поведение избежать и перенаправить | ||
| * вызов метода в очередь микрозадач. | ||
| */ | ||
| Promise.resolve().then(forceUpdate); |
There was a problem hiding this comment.
There was a problem hiding this comment.
не должны были. Этот метод всё-равно выполняется, но теперь в правильном порядке с точки зрения событийного цикла реакта
Yakutoc
approved these changes
Jun 9, 2023
kayman233
approved these changes
Jun 9, 2023
Yeti-or
approved these changes
Jun 13, 2023
| /* | ||
| * INFO: Метод forceUpdate содержит в себе flushSync и приводит | ||
| * к повторному рендеру компонента, который уже находится в процессе рендера. | ||
| * Данный хак, нужен для того, чтобы это поведение избежать и перенаправить |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Исправлено поведение компонентов
TooltipиPopup, при использовании которых при изменении стейта возникала ошибка: Warning: flushSync was called from inside a lifecycle method. React cannot flush when React is already rendering. Consider moving this call to a scheduler task or micro task.Это связано с тем, что в новой версии библиотеки
popperметодforceUpdateсодержит в себеflushSyncи приводит к повторному рендеру компонента, который уже находится в процессе рендера.🐤 Download canary assets:
color_sberHealth_ios-swift--canary.554.5210791882.swift
color_sberHealth_kotlin--canary.554.5210791882.kt
color_sberHealth_react-native--canary.554.5210791882.ts
color_sbermarket_business_ios-swift--canary.554.5210791882.swift
color_sbermarket_business_kotlin--canary.554.5210791882.kt
color_sbermarket_business_react-native--canary.554.5210791882.ts
color_sbermarket_ios-swift--canary.554.5210791882.swift
color_sbermarket_kotlin--canary.554.5210791882.kt
color_sbermarket_metro_ios-swift--canary.554.5210791882.swift
color_sbermarket_metro_kotlin--canary.554.5210791882.kt
color_sbermarket_metro_react-native--canary.554.5210791882.ts
color_sbermarket_react-native--canary.554.5210791882.ts
color_sbermarket_selgros_ios-swift--canary.554.5210791882.swift
color_sbermarket_selgros_kotlin--canary.554.5210791882.kt
color_sbermarket_selgros_react-native--canary.554.5210791882.ts
color_sbermarket_wlbusiness_ios-swift--canary.554.5210791882.swift
color_sbermarket_wlbusiness_kotlin--canary.554.5210791882.kt
color_sbermarket_wlbusiness_react-native--canary.554.5210791882.ts
color_sberonline_ios-swift--canary.554.5210791882.swift
color_sberonline_kotlin--canary.554.5210791882.kt
color_sberonline_react-native--canary.554.5210791882.ts
color_sberprime_ios-swift--canary.554.5210791882.swift
color_sberprime_kotlin--canary.554.5210791882.kt
color_sberprime_react-native--canary.554.5210791882.ts
shadow_sbermarket_react-native--canary.554.5210791882.ts
typo_mage_ios-swift--canary.554.5210791882.swift
typo_mage_kotlin--canary.554.5210791882.kt
typo_mage_react-native--canary.554.5210791882.ts
typo_plasma_ios-swift--canary.554.5210791882.swift
typo_plasma_kotlin--canary.554.5210791882.kt
typo_plasma_react-native--canary.554.5210791882.ts
typo_ruler_ios-swift--canary.554.5210791882.swift
typo_ruler_kotlin--canary.554.5210791882.kt
typo_ruler_react-native--canary.554.5210791882.ts
typo_sage_ios-swift--canary.554.5210791882.swift
typo_sage_kotlin--canary.554.5210791882.kt
typo_sage_react-native--canary.554.5210791882.ts
typo_sbermarket_ios-swift--canary.554.5210791882.swift
typo_sbermarket_kotlin--canary.554.5210791882.kt
typo_sbermarket_react-native--canary.554.5210791882.ts
typo_soulmate_ios-swift--canary.554.5210791882.swift
typo_soulmate_kotlin--canary.554.5210791882.kt
typo_soulmate_react-native--canary.554.5210791882.ts
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via:
Version
Published prerelease version:
@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]@salutejs/[email protected]Changelog
🚀 Enhancement
@salutejs/plasma-tokens-utils🐛 Bug Fix
@salutejs/plasma-core,@salutejs/plasma-hopePopupandTooltipcomponents #554 ([email protected])@salutejs/plasma-tokensdevAuthors: 4