fix: store timeframe ref in useState #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeframe ref is used internally and externally to perform all kinds of calculations, and to trigger width and direction updates according to the timeframe element if needed.
The problem
The current the ref is saved using a
useRef, meaning there is no way to detect changes in the ref after an unmount.This may be needed in situations where the timeline is mounted and unmounted in loading states.
When re-mounted, many listeners will no-longer work.
The solution
The timeline ref is now saved in a
useState, and changes to that state can be easily listened to by any event listener,useEffect,useCallbacketc.The timeline ref is now a part of the conventional react lifecycle.