Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MSE and peak error testing against source images #17

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

palemieux
Copy link
Contributor

@palemieux palemieux commented Dec 6, 2024

c1p1_04-0.j2c must be added to fate-suite\jpeg2000\itu-iso\codestreams_profile1

c1p1_04-0.zip

@osamu620
Copy link
Collaborator

Assuming the patch that fixes UBSAN, I got another UBSAN.

libavcodec/bytestream.h:171:15: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior libavcodec/bytestream.h:171:15 in
./tests/fate-run.sh: line 119: 77325 Abort trap: 6           $target_exec $target_path/"$@"
threads=1

for p1_02 and p1_03.

@osamu620
Copy link
Collaborator

I have tested the patch on a 32-bit environment. I got the following error.

--- ./tests/ref/fate/jpeg2000dec-ds1_ht_04_b9   2024-12-17 13:20:53.163749915 +0900
+++ tests/data/fate/jpeg2000dec-ds1_ht_04_b9    2024-12-17 13:21:13.619869688 +0900
@@ -3,4 +3,4 @@
 #codec_id 0: rawvideo
 #dimensions 0: 1024x1024
 #sar 0: 0/1
-0,          0,          0,        1,  2097152, 0x9df478aa
+0,          0,          0,        1,  2097152, 0x5b4dd999
Test jpeg2000dec-ds1_ht_04_b9 failed. Look at tests/data/fate/jpeg2000dec-ds1_ht_04_b9.err for details.
make: [tests/Makefile:311: fate-jpeg2000dec-ds1_ht_04_b9] Error 1 (ignored)

@palemieux
Copy link
Contributor Author

Can you run just this one:

fate-jpeg2000dec-p1_04

@osamu620
Copy link
Collaborator

osamu620 commented Dec 17, 2024

Can you run just this one:

fate-jpeg2000dec-p1_04

Looks good (No error was generated). Do you know the reason?

@palemieux
Copy link
Contributor Author

I implemented the MSE and peak error comparison only for that one! Look at the make file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants