Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mini.nvim #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for mini.nvim #101

wants to merge 1 commit into from

Conversation

tjkuson
Copy link

@tjkuson tjkuson commented Dec 25, 2024

Hi, here's my attempt at adding explicit support for mini.nvim.

I started by patching mini.pick and mini.files which are unusable on master (the colours for selected and unselected items are the same, making it impossible to tell what's selected). I then decided to add support for the rest of the plugins.
As a user of many of the mini.nvim modules, I tested the changes by running the fork locally.

When there was ambiguity, I took inspiration from how other themes have added support for mini.nvim and how other plugins have been supported via melange.

I appreciate this is a large PR and is difficult to test given the scope of mini.nvim, so please let me know if there is anything I can do to help with the review process!

Here are some screenshots of my nvim setup showing how mini.pick, mini.file, and mini.diff look respectively.

Screenshot 2024-12-25 at 04 49 18 Screenshot 2024-12-25 at 04 49 42 Screenshot 2024-12-25 at 14 12 57

Closes #95.

Checklist for Plugins

Paste link to documentation listing highlight groups:

  • (In colors/melange.lua) Add highlight groups
  • (In README.md) Add link to plugin source repository

@savq
Copy link
Owner

savq commented Dec 27, 2024

Hi @tjkuson, thanks for the PR, That's a lot of highlight groups!

When the highlight group has a sensible default, I generally prefer to keep it commented out (instead of defining the link again). But otherwise the PR looks good.

I started by patching mini.pick and mini.files which are unusable on master

Yeah, that's what prompted me to open the issue 😅 I just modified MiniPickMatchCurrent in my config, but thought knew that mini needed more stuff.

@tjkuson tjkuson force-pushed the mini.nvim branch 2 times, most recently from e9f752c to efa4fc1 Compare December 29, 2024 18:22
@tjkuson
Copy link
Author

tjkuson commented Dec 29, 2024

When the highlight group has a sensible default, I generally prefer to keep it commented out (instead of defining the link again).

I've revisited the groups and compared them with the mini.nvim code to comment out redundant redefinitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for all mini.nvim plugins
2 participants