Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam): add iam user resource #2152

Merged
merged 7 commits into from
Oct 12, 2023
Merged

feat(iam): add iam user resource #2152

merged 7 commits into from
Oct 12, 2023

Conversation

gbloquel
Copy link
Contributor

@gbloquel gbloquel commented Oct 9, 2023

Implements the resource iam_user

This PR closes #2088

@gbloquel
Copy link
Contributor Author

Hi @Codelax, @Monitob

Could you review my PR ?
I forgot to put a reviewer and as the workflow requires one.

regards,

@Codelax
Copy link
Member

Codelax commented Oct 11, 2023

Hello, thanks for your contribution.
I will keep your PR in mind and will not forget.
It is fine as you did, I will merge once I can spend more time on it.
Before releasing it we will review the features with the IAM team to be sure this is the best interface we can propose and check this is future proof.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5759d40) 73.19% compared to head (a91dccf) 73.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2152      +/-   ##
==========================================
+ Coverage   73.19%   73.25%   +0.05%     
==========================================
  Files         202      203       +1     
  Lines       32042    32152     +110     
==========================================
+ Hits        23454    23552      +98     
- Misses       6564     6573       +9     
- Partials     2024     2027       +3     
Files Coverage Δ
scaleway/provider.go 80.50% <100.00%> (+0.05%) ⬆️
scaleway/resource_iam_user.go 88.99% <88.99%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Oct 12, 2023
Merged via the queue into scaleway:master with commit 7ab4ccd Oct 12, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource IAM user
4 participants